Skip to content

feat(settings): Add sortFacetValuesBy - #351

Merged
ahmednfwela merged 1 commit into
mainfrom
sort-facet-settings
Sep 1, 2023
Merged

feat(settings): Add sortFacetValuesBy#351
ahmednfwela merged 1 commit into
mainfrom
sort-facet-settings

Conversation

@ahmednfwela

@ahmednfwela ahmednfwela commented Sep 1, 2023

Copy link
Copy Markdown
Collaborator

Pull Request

Related issue

Fixes #339

What does this PR do?

  • Add enum FacetingSortTypes
  • Add Map<String, FacetingSortTypes>? sortFacetValuesBy to Faceting
  • Updated .code-samples.meilisearch.yaml
  • [BREAKING] change members of Faceting to be final, and remove the default values set there.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@ahmednfwela

ahmednfwela commented Sep 1, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@brunoocasali looks like uploading to codecov failed for some reason, can you look into it ?

Update: looks like it's flakey, maybe due to rate limiting for not providing API key ?

brunoocasali
brunoocasali approved these changes Sep 1, 2023
View reviewed changes

@brunoocasali brunoocasali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ahmednfwela 🎉

bors merge

@meili-bors

meili-bors Bot commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

Build succeeded:

@ahmednfwela
ahmednfwela merged commit 7f67035 into main Sep 1, 2023
@ahmednfwela
ahmednfwela deleted the sort-facet-settings branch September 1, 2023 12:45
@curquiza curquiza added the enhancement New feature or request label Sep 13, 2023
@brunoocasali brunoocasali added the breaking-change The related changes are breaking for the users label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees

No one assigned

Labels

breaking-change The related changes are breaking for the users enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[v1.3] Sort facets value by alphanumerical or count order

3 participants

@ahmednfwela @brunoocasali @curquiza