You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Meilisearch v1.56] Add support for sampledCount in faceting sortFacetValuesBy #1004
Update the type/enum/constants for the sort value, if the SDK has one
Cover get, update, and reset faceting settings
Add test cases for the new value
Update faceting settings with sampledCount (* and per-attribute) and read them back
Add a code sample in .code-samples.meilisearch.yaml, under the update_faceting_settings_1 key, it should be the equivalent of the documentation's CURL example, using sampledCount.
Hi @Strift, I’d like to work on this. I’ll add the new facet sort value, check its JSON serialization, cover update/read/reset with local v1.56 tests, and add the requested code sample. Could you assign this to me?
hey @Strift i want to work on this issue . I propose adding sampledCount to the SDK’s sortFacetValuesBy type or enum, ensuring get, update, and reset operations correctly support the new value. I’d also add tests for wildcard (*) and per-attribute configurations, verify the settings can be read back, and update update_faceting_settings_1 in .code-samples.meilisearch.yaml with a matching example.
Feel free to open a PR for this, but we prefer not to assign issues. This sometimes discourages other contributors from opening a PR, and we've met users who asked to be assigned and never came back.
On Wed, Oct 28, 2026 at 12:16 PM Laurent Cazanove ***@***.***> wrote:
*Strift* left a comment (meilisearch/meilisearch-java#1004)
<#1004 (comment)>
Hello and thanks for your interest!
Feel free to open a PR for this, but we prefer not to assign issues. This
sometimes discourages other contributors from opening a PR, and we've met
users who asked to be assigned and never came back.
We are looking forward to reviewing your PR!
—
Reply to this email directly, view it on GitHub
<#1004?email_source=notifications&email_token=BQYWWRFGE6FHNDUEZLHRAKD5WGI25A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNBWGI2TQMRVGEYKM4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6462582510>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BQYWWREEWD576H2YW37UZI35WGI25AVCNFSNUABFKJSXA33TNF2G64TZHMZDGNZXGA3TIOBZHNEXG43VMU5TMMBVGE3TAOJSGA22C5QC>
.
You are receiving this because you commented.Message ID:
<meilisearch/meilisearch-java/issues/1004/6462582510 <(646)%20258-2510>@
github.com>
Activity
Pratham2511 commentedon Oct 27, 2026
Hi @Strift, I’d like to work on this. I’ll add the new facet sort value, check its JSON serialization, cover update/read/reset with local v1.56 tests, and add the requested code sample. Could you assign this to me?
cws31 commentedon Oct 27, 2026
hey @Strift i want to work on this issue . I propose adding
sampledCountto the SDK’ssortFacetValuesBytype or enum, ensuring get, update, and reset operations correctly support the new value. I’d also add tests for wildcard (*) and per-attribute configurations, verify the settings can be read back, and updateupdate_faceting_settings_1in.code-samples.meilisearch.yamlwith a matching example.Strift commentedon Oct 28, 2026
Hello and thanks for your interest!
Feel free to open a PR for this, but we prefer not to assign issues. This sometimes discourages other contributors from opening a PR, and we've met users who asked to be assigned and never came back.
We are looking forward to reviewing your PR!
Pratham2511 commentedon Oct 28, 2026
Thanks @Strift, I’ve opened #1005 for this. Please have a look when you get a chance.
cws31 commentedon Oct 28, 2026