Skip to content

CreateIndex returns Index instance, tested #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

CreateIndex returns Index instance, tested #39

merged 1 commit into from
Oct 15, 2020

Conversation

eskombro
Copy link
Member

Closes #38

@eskombro eskombro requested a review from curquiza October 15, 2020 09:12
curquiza
curquiza approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easier for the user! Great change! 😁

@eskombro eskombro merged commit 5e0cf0e into master Oct 15, 2020
@curquiza curquiza deleted the create_index_returns_an_index_instance branch November 25, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateIndex should return an Index instance
2 participants
@eskombro @curquiza