Skip to content

Code samples changes related to Meilisearch release (v0.28.0) - #409

Merged
alallema merged 6 commits into
bump-meilisearch-v0.28.0from
meili-bot/code-samples-v0-28
Jan 17, 2023
Merged

alallema merged 6 commits into
bump-meilisearch-v0.28.0from
meili-bot/code-samples-v0-28

Conversation

@meili-bot

@meili-bot meili-bot commented Jul 4, 2022 •

Copy link
Copy Markdown
Contributor

This PR is auto-generated.

Update the code-samples.meilisearch.yml according to the integration-guides issue for more information and the complete description about what should be done here check that issue.

@meili-bot meili-bot added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels Jul 4, 2022
@alallema
alallema marked this pull request as ready for review January 10, 2023 16:07
@alallema
alallema requested a review from brunoocasali January 10, 2023 19:17
# the documentation on build
# You can read more on https://github.com/meilisearch/documentation/tree/master/.vuepress/code-samples
---
getting_started_typo_tolerance: |-

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid code-sample @alallema. I think you can keep it, even if the feature is not available in the SDK yet.

see more:
https://github.com/meilisearch/documentation/blob/main/.code-samples.meilisearch.yaml#L864

@alallema alallema Jan 16, 2023 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove it it is on line 232. Sorry is confusing to move sample when there is a lot of them ...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice then! Thaanks!

Comment thread .code-samples.meilisearch.yaml Resolved
Comment thread .code-samples.meilisearch.yaml Resolved
alallema and others added 3 commits January 16, 2023 19:35
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
Co-authored-by: Bruno Casali <brunoocasali@gmail.com>
@alallema
alallema requested a review from brunoocasali January 16, 2023 18:46

@brunoocasali brunoocasali left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats!! 🍣

@alallema
alallema merged commit 787a974 into bump-meilisearch-v0.28.0 Jan 17, 2023
@alallema
alallema deleted the meili-bot/code-samples-v0-28 branch January 17, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants