Skip to content

Conversation

@eskombro
Copy link
Contributor

No description provided.

@eskombro eskombro requested a review from curquiza October 21, 2020 22:46
@eskombro eskombro force-pushed the update_readme branch 5 times, most recently from e7b2e96 to cfe07ac Compare October 21, 2020 22:57
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I requested some minor changes

README.md Outdated
+ "]";

Client client = new Client(new Config("http://localhost:7700", "masterKey"));
Index index = client.createIndex("books");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if it's going to be changed, could you add the line with the getIndex? Like in this README

eskombro and others added 2 commits October 27, 2020 02:50
Co-authored-by: Clémentine Urquizar <[email protected]>
@eskombro eskombro merged commit 54d25f8 into master Oct 27, 2020
@curquiza curquiza deleted the update_readme branch November 25, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants