Skip to content

Custom Exceptions: MeiliSearchException => MeiliSearchApiException + MeiliSearchConnectionException #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2020
Merged

Custom Exceptions: MeiliSearchException => MeiliSearchApiException + MeiliSearchConnectionException #46

merged 4 commits into from
Nov 4, 2020

Conversation

eskombro
Copy link
Member

@eskombro eskombro commented Oct 27, 2020 •
edited
Loading

This PR introduces Custom Exceptions:

MeiliSearchException:

  • MeiliSearchApiException => Errors comming from MeiliSearch HTTP API
  • MeiliSearchCommunicationException => Erros while unsuccessfully trying to communicate with MeiliSearch

Closes #7

@eskombro eskombro marked this pull request as draft October 27, 2020 13:53
@eskombro eskombro force-pushed the add_custom_exceptions branch 5 times, most recently from 7b22027 to 379c4a3 Compare October 27, 2020 16:33
@eskombro eskombro force-pushed the add_custom_exceptions branch from 379c4a3 to 2f0d66d Compare October 27, 2020 16:35
@eskombro eskombro changed the title Initialize MeiliSearchException class Custom Exceptions: MeiliSearchException, MeiliSearchApiException, MeiliSearchConnectionException Oct 27, 2020
@eskombro eskombro changed the title Custom Exceptions: MeiliSearchException, MeiliSearchApiException, MeiliSearchConnectionException Custom Exceptions: MeiliSearchException => MeiliSearchApiException + MeiliSearchConnectionException Oct 27, 2020
@eskombro eskombro force-pushed the add_custom_exceptions branch from 636d310 to b1c9112 Compare October 27, 2020 18:06
@eskombro eskombro force-pushed the add_custom_exceptions branch 2 times, most recently from 1d9a022 to f0a227f Compare October 29, 2020 02:31
@eskombro eskombro force-pushed the add_custom_exceptions branch from f0a227f to 20cbded Compare October 29, 2020 02:45
@eskombro eskombro marked this pull request as ready for review November 4, 2020 00:13
@eskombro eskombro merged commit 04f855c into master Nov 4, 2020
@curquiza curquiza deleted the add_custom_exceptions branch November 25, 2020 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup custom exceptions
1 participant
@eskombro