-
Notifications
You must be signed in to change notification settings - Fork 122
Update Keys API for Meilisearch v.28 #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
588a95c
Apply keys changes
alallema a4f18a9
Add toQuery method to KeysQuery
alallema 2910675
Update src/main/java/com/meilisearch/sdk/Client.java
alallema 5c5ce8d
Update src/main/java/com/meilisearch/sdk/Client.java
alallema 1c7b8cf
Improve Key's method description
alallema c121bd7
Update src/main/java/com/meilisearch/sdk/model/KeysQuery.java
alallema fc137ae
Update src/test/java/com/meilisearch/integration/KeysTest.java
alallema c95847c
Modify KeyUpdate class definition
alallema 4a6c382
Changes du to review and linter
alallema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
package com.meilisearch.sdk.model; | ||
|
||
import lombok.Getter; | ||
import lombok.Setter; | ||
import lombok.experimental.Accessors; | ||
|
||
/** | ||
* Data structure for updating a Key | ||
* | ||
* <p>https://docs.meilisearch.com/reference/api/keys.html | ||
*/ | ||
@Getter | ||
public class KeyUpdate { | ||
@Setter | ||
@Accessors(chain = true) | ||
protected String name = null; | ||
|
||
@Setter | ||
@Accessors(chain = true) | ||
protected String description = null; | ||
|
||
public KeyUpdate() {} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
package com.meilisearch.sdk.model; | ||
|
||
import com.meilisearch.sdk.http.URLBuilder; | ||
import lombok.Getter; | ||
import lombok.Setter; | ||
import lombok.experimental.Accessors; | ||
|
||
/** | ||
* Data structure of the query parameters for the keys routes | ||
* | ||
* <p>https://docs.meilisearch.com/reference/api/keys.html#query-parameters | ||
*/ | ||
@Setter | ||
@Getter | ||
@Accessors(chain = true) | ||
public class KeysQuery { | ||
private int offset = -1; | ||
private int limit = -1; | ||
|
||
public KeysQuery() {} | ||
|
||
public String toQuery(String key) { | ||
URLBuilder urlb = new URLBuilder(); | ||
urlb.addSubroute("keys").addSubroute(key); | ||
return urlb.getURL(); | ||
} | ||
|
||
public String toQuery(KeysQuery param) { | ||
URLBuilder urlb = new URLBuilder(); | ||
urlb.addSubroute("keys") | ||
.addParameter("limit", param.getLimit()) | ||
.addParameter("offset", param.getOffset()); | ||
return urlb.getURL(); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.