Skip to content

Commit 7f20d0b

Browse files
committed
Remove unecessary types (#1049)
1 parent 0211825 commit 7f20d0b

File tree

6 files changed

+20
-45
lines changed

6 files changed

+20
-45
lines changed

packages/instant-meilisearch/src/adapter/search-request-adapter/search-params-adapter.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,6 @@ function setFinitePagination(
6868
* to meilisearch search query parameters.
6969
*
7070
* @param {SearchContext} searchContext
71-
*
72-
* @returns {MeiliSearchParams}
7371
*/
7472
export function MeiliParamsCreator(searchContext: SearchContext) {
7573
const meiliSearchParams: any = {}

packages/instant-meilisearch/src/adapter/search-request-adapter/search.ts

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/instant-meilisearch/src/adapter/search-response-adapter/__tests__/pagination-adapter.test.ts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,6 +401,7 @@ describe.each(finitePaginateHitsTestsParameters)(
401401
processingTimeMs: 0,
402402
query: '',
403403
totalPages,
404+
indexUid: '',
404405
},
405406
{ hitsPerPage, page, finite: true }
406407
)
@@ -421,7 +422,7 @@ describe.each(lazyPaginateHitsTestsParameters)(
421422
adaptedPagination
422423
)} where limit is ${limit} in the response and where the instantsearch pagination context is page: ${page} and hitsPerPage: ${hitsPerPage}`, () => {
423424
const response = adaptPaginationParameters(
424-
{ hits, limit, offset, processingTimeMs: 0, query: '' },
425+
{ hits, limit, offset, processingTimeMs: 0, query: '', indexUid: '' },
425426
{ hitsPerPage, page, finite: false }
426427
)
427428

@@ -436,7 +437,14 @@ it('Should throw when hitsPerPage is negative', () => {
436437
const hitsPerPage = -1
437438
const page = 0
438439
adaptPaginationParameters(
439-
{ hits, page: page + 1, hitsPerPage, processingTimeMs: 0, query: '' },
440+
{
441+
hits,
442+
page: page + 1,
443+
hitsPerPage,
444+
processingTimeMs: 0,
445+
query: '',
446+
indexUid: '',
447+
},
440448
{ hitsPerPage, page, finite: true }
441449
)
442450
} catch (e: any) {

packages/instant-meilisearch/src/adapter/search-response-adapter/pagination-adapter.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
import type {
2-
MeiliSearchResponse,
2+
MultiSearchResult,
33
InstantSearchPagination,
44
PaginationState,
55
} from '../../types'
66

77
function adaptNbPages(
8-
searchResponse: MeiliSearchResponse<Record<string, any>>,
8+
searchResponse: MultiSearchResult<Record<string, any>>,
99
hitsPerPage: number
1010
): number {
1111
if (searchResponse.totalPages != null) {
@@ -23,7 +23,7 @@ function adaptNbPages(
2323
}
2424

2525
export function adaptPaginationParameters(
26-
searchResponse: MeiliSearchResponse<Record<string, any>>,
26+
searchResponse: MultiSearchResult<Record<string, any>>,
2727
paginationState: PaginationState
2828
): InstantSearchPagination & { nbPages: number } {
2929
const { hitsPerPage, page } = paginationState

packages/instant-meilisearch/src/adapter/search-response-adapter/total-hits-adapter.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import type { MeiliSearchResponse } from '../../types'
1+
import type { MultiSearchResult } from '../../types'
22

33
export function adaptTotalHits(
4-
searchResponse: MeiliSearchResponse<Record<string, any>>
4+
searchResponse: MultiSearchResult<Record<string, any>>
55
): number {
66
const {
77
hitsPerPage = 0,

packages/instant-meilisearch/src/types/types.ts

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,24 +2,19 @@ import type { SearchClient } from 'instantsearch.js'
22
import type { MultipleQueriesQuery as AlgoliaMultipleQueriesQuery } from '@algolia/client-search'
33

44
import type {
5-
SearchParams as MeiliSearchParams,
6-
SearchResponse as MeiliSearchResponse,
7-
MultiSearchResponse as MeilisearchMultiSearchResponse,
5+
MultiSearchQuery as MeiliSearchMultiSearchParams,
6+
MultiSearchResult,
87
} from 'meilisearch'
98

10-
export type {
11-
AlgoliaMultipleQueriesQuery,
12-
MeilisearchMultiSearchResponse,
13-
MeiliSearchParams,
14-
MeiliSearchResponse,
15-
}
9+
export type { AlgoliaMultipleQueriesQuery, MultiSearchResult }
1610
export type { SearchResponse as AlgoliaSearchResponse } from '@algolia/client-search'
1711

1812
export type {
1913
Filter,
2014
FacetDistribution,
2115
MeiliSearch,
2216
FacetStats as MeiliFacetStats,
17+
MultiSearchQuery as MeiliSearchMultiSearchParams,
2318
} from 'meilisearch'
2419

2520
export type InstantSearchParams = AlgoliaMultipleQueriesQuery['params']
@@ -79,15 +74,8 @@ export type InstantSearchPagination = {
7974
nbPages: number
8075
}
8176

82-
export type Facets = string | string[] | undefined
83-
84-
export type MeiliSearchMultiSearchParams = MeiliSearchParams & {
85-
indexUid: string
86-
}
87-
8877
export type MeilisearchMultiSearchResult<T = Record<string, any>> =
89-
MeiliSearchResponse<T> & {
90-
indexUid: string
78+
MultiSearchResult<T> & {
9179
pagination: PaginationState
9280
}
9381

0 commit comments

Comments
 (0)