Skip to content

Remove unecessary types #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

bidoubiwa
Copy link
Contributor

As per the last update of meilisearch-js, new types were introduced that removes the need of instant-meilisearch re-creating them.

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Mar 29, 2023
@bidoubiwa bidoubiwa requested review from alallema and mdubus March 29, 2023 13:10
@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: 81b1998

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bidoubiwa bidoubiwa force-pushed the remove_unused_types branch from 5165add to 81b1998 Compare March 29, 2023 15:53
@bidoubiwa bidoubiwa requested a review from mdubus March 30, 2023 10:56
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨🦕

@bidoubiwa bidoubiwa merged commit 3f0ab74 into bump-meilisearch-v1.1.0 Mar 30, 2023
@bidoubiwa bidoubiwa deleted the remove_unused_types branch March 30, 2023 12:13
bidoubiwa added a commit that referenced this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants