Skip to content

Remove unecessary types #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,6 @@ function setFinitePagination(
* to meilisearch search query parameters.
*
* @param {SearchContext} searchContext
*
* @returns {MeiliSearchParams}
*/
export function MeiliParamsCreator(searchContext: SearchContext) {
const meiliSearchParams: any = {}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import type {
MeiliSearchResponse,
MultiSearchResult,
InstantSearchPagination,
PaginationState,
} from '../../types'

function adaptNbPages(
searchResponse: MeiliSearchResponse<Record<string, any>>,
searchResponse: MultiSearchResult<Record<string, any>>,
hitsPerPage: number
): number {
if (searchResponse.totalPages != null) {
Expand All @@ -23,7 +23,7 @@ function adaptNbPages(
}

export function adaptPaginationParameters(
searchResponse: MeiliSearchResponse<Record<string, any>>,
searchResponse: MultiSearchResult<Record<string, any>>,
paginationState: PaginationState
): InstantSearchPagination & { nbPages: number } {
const { hitsPerPage, page } = paginationState
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { MeiliSearchResponse } from '../../types'
import type { MultiSearchResult } from '../../types'

export function adaptTotalHits(
searchResponse: MeiliSearchResponse<Record<string, any>>
searchResponse: MultiSearchResult<Record<string, any>>
): number {
const {
hitsPerPage = 0,
Expand Down
22 changes: 5 additions & 17 deletions packages/instant-meilisearch/src/types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,19 @@ import type { SearchClient } from 'instantsearch.js'
import type { MultipleQueriesQuery as AlgoliaMultipleQueriesQuery } from '@algolia/client-search'

import type {
SearchParams as MeiliSearchParams,
SearchResponse as MeiliSearchResponse,
MultiSearchResponse as MeilisearchMultiSearchResponse,
MultiSearchQuery as MeiliSearchMultiSearchParams,
MultiSearchResult,
} from 'meilisearch'

export type {
AlgoliaMultipleQueriesQuery,
MeilisearchMultiSearchResponse,
MeiliSearchParams,
MeiliSearchResponse,
}
export type { AlgoliaMultipleQueriesQuery, MultiSearchResult }
export type { SearchResponse as AlgoliaSearchResponse } from '@algolia/client-search'

export type {
Filter,
FacetDistribution,
MeiliSearch,
FacetStats as MeiliFacetStats,
MultiSearchQuery as MeiliSearchMultiSearchParams,
} from 'meilisearch'

export type InstantSearchParams = AlgoliaMultipleQueriesQuery['params']
Expand Down Expand Up @@ -79,15 +74,8 @@ export type InstantSearchPagination = {
nbPages: number
}

export type Facets = string | string[] | undefined

export type MeiliSearchMultiSearchParams = MeiliSearchParams & {
indexUid: string
}

export type MeilisearchMultiSearchResult<T = Record<string, any>> =
MeiliSearchResponse<T> & {
indexUid: string
MultiSearchResult<T> & {
pagination: PaginationState
}

Expand Down