Skip to content

Prototype beta/prototype search for facet values #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jun 6, 2023

New

Add compatibility with the searchable parameter of the RefinementList widget

TODO

  • work keepzerofacets compatibility

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 664221d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@meilisearch/instant-meilisearch Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bidoubiwa bidoubiwa force-pushed the prototype-beta/prototype-search-for-facet-values branch from b5cf8ec to dc78c4d Compare June 8, 2023 14:11
@bidoubiwa bidoubiwa force-pushed the prototype-beta/prototype-search-for-facet-values branch from dc78c4d to ce80532 Compare June 8, 2023 14:14
@gmourier
Copy link
Member

I was testing the search for facet values prototype with the instant-meilisearch refinement list.

So far, it works well. The only feedback I can think of is that the search box stays filled with my facet query when documents change because of further action (like an update of the search bar or a click on another facet value)

In that case, I would like the RefinementList search box to be emptied

meili-bot and others added 3 commits July 11, 2023 21:56
1190: Add Meilisearch Cloud free trial statement r=brunoocasali a=meili-bot

_This PR is auto-generated._

Add Meilisearch Cloud free trial statement.

Related to: meilisearch/integration-guides#277


Co-authored-by: meili-bot <[email protected]>
@bidoubiwa bidoubiwa changed the base branch from main to bump-meilisearch-v1.3.0 July 13, 2023 09:17
@bidoubiwa bidoubiwa changed the base branch from bump-meilisearch-v1.3.0 to add_search_for_facet_values July 13, 2023 09:26
@bidoubiwa bidoubiwa marked this pull request as ready for review July 13, 2023 09:26
@bidoubiwa bidoubiwa merged commit d3695c2 into add_search_for_facet_values Jul 13, 2023
@bidoubiwa bidoubiwa deleted the prototype-beta/prototype-search-for-facet-values branch July 13, 2023 09:26
bidoubiwa added a commit that referenced this pull request Jul 18, 2023
* Prototype beta/prototype search for facet values (#1144)

* Add prototype beta changeset

* Add compatibility with searchable on facetRefinements

* Add changeset for searchable parameter

* Merge

* Add a facet search context

* Update changeset

* Update pre mode

* Update pre mode

* Update pre mode

* Version Packages (prototype-search-for-facet-values) (#1158)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update README.md

* Remove pre changeset mode

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: meili-bot <[email protected]>
Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com>

* Remove changelog

* Rollback unexpected changes

* Update meilisearch to latest rc

* Fix cypress tests

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: meili-bot <[email protected]>
Co-authored-by: meili-bors[bot] <89034592+meili-bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants