allow symfony/http-client 8.0#820
Conversation
WalkthroughUpdated the Symfony HttpClient dev dependency in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
composer.json(1 hunks)
🔇 Additional comments (1)
composer.json (1)
59-68: PR appears incomplete per the checklist.The PR description indicates an unchecked checklist with an ellipsis in the "What does this PR do?" section, suggesting the PR is a draft or not ready for review. Confirm that:
- The change rationale and scope are clear
- All contributor requirements (guidelines, tests) have been fulfilled
- Testing against Symfony 8.0 (RC2) has been performed
Symfony 8 is in RC2 and will be out very soon.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #820 +/- ##
==========================================
- Coverage 89.78% 88.14% -1.65%
==========================================
Files 59 78 +19
Lines 1449 1687 +238
==========================================
+ Hits 1301 1487 +186
- Misses 148 200 +52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thank you @tacman |
Symfony 8 is in RC2 and will be out very soon.
Pull Request
Related issue
Fixes #<issue_number>
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit