Skip to content

allow symfony/http-client 8.0#820

Merged
norkunas merged 1 commit into
meilisearch:mainfrom
tacman:patch-4
Nov 19, 2025
Merged

allow symfony/http-client 8.0#820
norkunas merged 1 commit into
meilisearch:mainfrom
tacman:patch-4

Conversation

@tacman

@tacman tacman commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Symfony 8 is in RC2 and will be out very soon.

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

Summary by CodeRabbit

  • Chores
    • Expanded development dependency version constraints for the Symfony HTTP Client to include v8.0, enabling compatibility with newer framework releases. No runtime behavior or error-handling changes were made. This change only affects allowed versions during development/CI and does not alter application functionality; package resolution may now select newer client releases.

@coderabbitai

coderabbitai Bot commented Nov 18, 2025

Copy link
Copy Markdown

Walkthrough

Updated the Symfony HttpClient dev dependency in composer.json to allow ^8.0 in addition to the existing ^5.4, ^6.0, and ^7.0 constraints; no application logic or error handling was changed. (50 words)

Changes

Cohort / File(s) Summary
Dependency Version Expansion
composer.json
Expanded Symfony HttpClient dev requirement from ``^5.4

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Files to spot-check: composer.json (verify constraint syntax and any lockfile implications).

Poem

🐰 A tiny hop in a single line,
The client accepts Eight — all will align.
No logic to change, just versions made new,
I nibble the diff and give it a chew. ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'allow symfony/http-client 8.0' directly and clearly describes the main change in the changeset: adding support for symfony/http-client version 8.0 to the composer.json dev requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c0835d and 3247839.

📒 Files selected for processing (1)
  • composer.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • composer.json

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e402d00 and 3c0835d.

📒 Files selected for processing (1)
  • composer.json (1 hunks)
🔇 Additional comments (1)
composer.json (1)

59-68: PR appears incomplete per the checklist.

The PR description indicates an unchecked checklist with an ellipsis in the "What does this PR do?" section, suggesting the PR is a draft or not ready for review. Confirm that:

  • The change rationale and scope are clear
  • All contributor requirements (guidelines, tests) have been fulfilled
  • Testing against Symfony 8.0 (RC2) has been performed

Comment thread composer.json
Symfony 8 is in RC2 and will be out very soon.
@codecov

codecov Bot commented Nov 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (0078a8c) to head (3247839).
⚠️ Report is 82 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
- Coverage   89.78%   88.14%   -1.65%     
==========================================
  Files          59       78      +19     
  Lines        1449     1687     +238     
==========================================
+ Hits         1301     1487     +186     
- Misses        148      200      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@norkunas norkunas added this pull request to the merge queue Nov 19, 2025
Merged via the queue into meilisearch:main with commit 4d90618 Nov 19, 2025
10 of 11 checks passed
@norkunas

Copy link
Copy Markdown
Collaborator

Thank you @tacman

@Strift Strift added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants