Skip to content

Add keys parameter in missing routes v0.28.x #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alallema
Copy link
Contributor

  • delete_key and update_key are also able to be recognizable by either the uid or the key.

@alallema alallema requested a review from bidoubiwa June 30, 2022 08:26
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@alallema alallema force-pushed the add_keys_parameter_in_missing_routes branch from f0458a9 to e5569bb Compare June 30, 2022 08:39
@alallema alallema force-pushed the add_keys_parameter_in_missing_routes branch from e5569bb to 36e1f8d Compare June 30, 2022 08:48
@alallema
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Jun 30, 2022
489: Add keys parameter in missing routes v0.28.x r=alallema a=alallema

- `delete_key` and `update_key` are also able to be recognizable by either the `uid` or the `key`.

Co-authored-by: alallema <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 30, 2022

Build failed:

@alallema alallema merged commit d77346a into bump-meilisearch-v0.28.0 Jun 30, 2022
@alallema alallema deleted the add_keys_parameter_in_missing_routes branch June 30, 2022 09:15
bors bot added a commit that referenced this pull request Jul 11, 2022
472: Changes related to the next Meilisearch release (v0.28.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#205

This PR:
- gathers the changes related to the next Meilisearch release (v0.28.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases).
- might eventually contain test failures until the Meilisearch v0.28.0 is out.

⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.28.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #474
- #475
- #476 
- #477 
- #478 
- #479
- #481
- #484
- #489

Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>
Co-authored-by: Amélie <[email protected]>
Co-authored-by: alallema <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants