Skip to content

Implement wait_for_pending_update method #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2020
Merged

Implement wait_for_pending_update method #81

merged 1 commit into from
May 27, 2020

Conversation

eskombro
Copy link
Member

[previously discussed in #79]

Based on this discussion, SDKs must provide a method that waits synchronously for an update to be processed by MeiliSearch.

Parameters:

  • update_id: id of the update to be waited

Optional parameters:

  • timeout_in_ms max number of millisecond this method should wait before rising a TimeoutError (default=2000ms)
  • interval_in_ms number of millisecond to set an interval of time this method should wait (sleep) between requests (default=10ms)

tests

  • Added wait_for_pending_update method in the Index class
  • Added tests for default values, test for timeout and test for interval.

Closes #64

@eskombro eskombro requested review from curquiza and bidoubiwa May 27, 2020 12:38
@eskombro eskombro force-pushed the wait_for_pending_update_method branch 2 times, most recently from ca2d2e0 to ab5d78b Compare May 27, 2020 12:43
curquiza
curquiza previously approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

bidoubiwa
bidoubiwa previously approved these changes May 27, 2020
View reviewed changes
@eskombro eskombro dismissed stale reviews from bidoubiwa and curquiza via 6e7edac May 27, 2020 13:07
@eskombro eskombro force-pushed the wait_for_pending_update_method branch from ab5d78b to 6e7edac Compare May 27, 2020 13:07
@eskombro eskombro merged commit 5925f7b into master May 27, 2020
@eskombro eskombro deleted the wait_for_pending_update_method branch May 27, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza left review comments

@bidoubiwa bidoubiwa bidoubiwa left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait_for_pending_update method
3 participants
@eskombro @curquiza @bidoubiwa