Skip to content

Update deployment workflow - #811

Merged
meili-bors[bot] merged 6 commits into
mainfrom
migrate-docs
Jul 26, 2023
Merged

Update deployment workflow#811
meili-bors[bot] merged 6 commits into
mainfrom
migrate-docs

Conversation

@Strift

@Strift Strift commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

Pull Request

What does this PR do?

Update the documentation.yml to:

  • Separate build & deploy steps
  • Create a CNAME file in the built files folder
  • Deploy the built files to Github Pages environment
  • Allow the workflow to run manually

Additionally, this PR removes the CNAME file from the root of the repo.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@Strift
Strift temporarily deployed to github-pages July 25, 2023 15:00 — with GitHub Actions Inactive
@Strift
Strift marked this pull request as draft July 25, 2023 15:15
@Strift
Strift temporarily deployed to github-pages July 25, 2023 15:17 — with GitHub Actions Inactive
@Strift
Strift marked this pull request as ready for review July 26, 2023 08:58
@Strift

Strift commented Jul 26, 2023

Copy link
Copy Markdown
Contributor Author

Hey @sanders41 @alallema,

The docs is working again https://python-sdk.meilisearch.com 🎉

This PR is ready to be merged. We can also close #812.

Thanks for your assistance. 🙏

@alallema alallema left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @Strift 🎉
LGTM!
I let @sanders41 merge it when it suits him unless you'd prefer me to do it.

@sanders41 sanders41 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also

@sanders41

Copy link
Copy Markdown
Collaborator

bors merge

@meili-bors

meili-bors Bot commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

@meili-bors
meili-bors Bot merged commit 3b8829a into main Jul 26, 2023
@meili-bors
meili-bors Bot deleted the migrate-docs branch July 26, 2023 11:55
@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Jul 27, 2023
meili-bors Bot added a commit that referenced this pull request Jul 31, 2023
815: Update version for the next release (v0.28.2) r=sanders41 a=meili-bot

This version introduces features released on Meilisearch v1.3.0 🎉
Check out the changelog of [Meilisearch v1.3.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.3.0) for more information on the changes. 

⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version.

## 🚀 Enhancements

* ⚠️ **EXPERIMENTAL**: Adds docstring and tests for vector search (#805) `@sanders41` 

⚠️ The EXPERIMENTAL features are not covered by semver. To explicitly opt-in, check this [guide](https://www.meilisearch.com/docs/reference/api/experimental-features).

## 🐛 Bug Fixes

* Fix potential json_encoding date error and truncation in pydantic < 2 (#807) `@sanders41`

## 💅 Misc

* Migrate docs hosting to Meilisearch subdomain (#810) `@Strift`
* Update documentation deployment workflow (#811) `@Strift` 

Thanks again to `@Strift,` `@alallema,` and `@sanders41!` 🎉

Co-authored-by: meili-bot <74670311+meili-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants