Skip to content

Add code samples and remove useless ones #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Sep 20, 2023

I created scripts to manage code samples (internal only).

The script mostly compare the code samples of the SDK with the one in the docs

  1. I found out the following code samples are still in this repo but not used by the documentation anymore, so I removed them:
meilisearch-python
- 'facet_search_2' not found
- 'search_parameter_guide_show_ranking_score_1' not found
- 'search_parameter_guide_attributes_to_search_on_1' not found
  1. I found the following code samples were missing:
meilisearch-python
- 'documents_guide_add_movie_1' not found in documentation
- 'getting_started_communicating_with_a_protected_instance' not found in documentation
- 'faceted_search_facets_1' not found in documentation
- 'faceted_search_2' not found in documentation

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a4b6513) 100.00% compared to head (20a3129) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #847   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          720       720           
=========================================
  Hits           720       720           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sanders41
Copy link
Collaborator

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Sep 20, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants