Add sort_facet_values_by to Faceting model - #848
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 720 721 +1
=========================================
+ Hits 720 721 +1
☔ View full report in Codecov by Sentry. |
sanders41
commented
Sep 20, 2023
curquiza
approved these changes
Sep 21, 2023
curquiza
left a comment
Member
There was a problem hiding this comment.
Thank you @sanders41
I let you merge when you want 😄
Collaborator
Author
|
bors merge |
Contributor
|
Build succeeded:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
@curquiza this is what is needed in addition to the code samples for #829
Related issue
Fixes #829
What does this PR do?
sort_facet_values_byto theFacetingmodelPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!