Add pagination handler using finite pagination #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
added
the
breaking-change
|
I put the PR in draft mode because I need to release the ruby. But you're welcome to review :) |
brunoocasali
commented
Nov 16, 2022
| @@ -35,7 +35,7 @@ def create(results, total_hits, options = {}) | |||
| if array.empty? && !results.empty? | |||
| # since Kaminari 0.16.0, you need to pad the results with nil values so it matches the offset param | |||
| # otherwise you'll get an empty array: https://github.com/amatsuda/kaminari/commit/29fdcfa8865f2021f710adaedb41b7a7b081e34d | |||
| results = ([nil] * offset) + results | |||
| results = Array.new(offset) + results | |||
There was a problem hiding this comment.
Just a cosmetic change 💅
curquiza
reviewed
Nov 17, 2022
brunoocasali
deleted the
bump-meilisearch-v0.30.0-add-limited-pagination
branch
Merged
bors bot
added a commit
that referenced
this pull request
Dec 1, 2022
217: Release v0.8.0 r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.30.0 🎉 Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes. ##⚠️ Breaking changes This release is **only** compatible with the latest version of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) and greater * Rename meilisearch_host to meilisearch_url (#197) `@AdoPi` ## 🚀 Enhancements * Add the ability to define `pagination` settings in the model directly. (#208) `@yagince` * Use **finite pagination** strategy when `pagination_backend` is defined. (#214) `@brunoocasali` Read more about it [here](meilisearch/specifications#196) Thanks again to `@AdoPi,` `@brunoocasali,` `@curquiza,` and `@yagince!` 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change was more straightforward than I expected. I removed the placeholder search and mapped the response from the Meilisearch server. Also, I ensure we will always have a
page = 1when we have apagination_backendset.All the tests passed locally (by using meilisearch-ruby with the v0.30 changes). So I can assume, based on our coverage, we are good to go.