Skip to content

Adding possibility to send body null and tests #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2021

Conversation

alallema
Copy link
Contributor

@alallema alallema commented May 5, 2021

Description
Adding the possibility for the client to send body null.
Fixing update settings method.
Adding tests to check if nil could be sent properly.

Issue related
#121


Still not working on update_synonyms() and update_stop_words() method because the meilisearch API doesn't seem to take null as arguments

@alallema alallema requested a review from curquiza May 5, 2021 07:17
curquiza
curquiza previously approved these changes May 5, 2021
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm, the synonyms and the stop words cannot be updated with null via the MeiliSearch API. I will open an issue to fix this in transplant once all the settings are implemented in.

Waiting for the approval of @bidoubiwa before any merge

@curquiza curquiza requested a review from bidoubiwa May 5, 2021 07:41
@curquiza curquiza added skip-changelog The PR will not appear in the release changelogs and removed skip-changelog The PR will not appear in the release changelogs labels May 5, 2021
@curquiza curquiza linked an issue May 5, 2021 that may be closed by this pull request
2 tasks
@curquiza
Copy link
Member

curquiza commented May 5, 2021

2 remarks:

  • your issue was not linked with this PR, even if you mentioned it in the description. I added it 😉 It's important so that the issue is closed automatically by GitHub once the PR is merged. Sometimes (depending on how you mention it and how many issues you mention) GitHub does not link the issue in the PR, unfortunately you have to check every time 😅
  • The linter fails: this section in the CONTRIBUTING might help you fix it: https://github.com/meilisearch/meilisearch-ruby/blob/main/CONTRIBUTING.md#linter

@alallema alallema requested a review from curquiza May 5, 2021 07:52
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 5, 2021

@bors bors bot merged commit e3f8951 into main May 5, 2021
@bors bors bot deleted the fix-updating_settings_with_nil branch May 5, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update settings with nil
3 participants