-
Notifications
You must be signed in to change notification settings - Fork 47
Adding possibility to send body null and tests #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm, the synonyms and the stop words cannot be updated with null
via the MeiliSearch API. I will open an issue to fix this in transplant once all the settings are implemented in.
Waiting for the approval of @bidoubiwa before any merge
Co-authored-by: Clémentine Urquizar <[email protected]>
2 remarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥
bors merge |
Build succeeded: |
Description
Adding the possibility for the client to send body null.
Fixing update settings method.
Adding tests to check if nil could be sent properly.
Issue related
#121
Still not working on
update_synonyms()
andupdate_stop_words()
method because the meilisearch API doesn't seem to take null as arguments