Skip to content

Simplify files organization #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 25, 2020
Merged

Simplify files organization #36

merged 1 commit into from
May 25, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented May 24, 2020

Closes #36

@eskombro, I anticipate your question: the .rubocop_todo.yml is a file that gathers all the lint rules which are not followed. It's autogenerated with the rubocop --auto-gen-config. You have to do this command at the end, when you are ok with all the remained linter errors.
Hope I'm clear 😇

Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that was a nice read!

In python I finally decided to delete the patch request under your own advice, so here I am, asking you the same thing back! :)

@curquiza
Copy link
Member Author

Changes are done! I completely forgot the patch stuff! Thanks

@curquiza curquiza requested a review from eskombro May 25, 2020 10:25
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@curquiza curquiza merged commit c39c607 into master May 25, 2020
@curquiza curquiza deleted the refacto branch May 25, 2020 10:34
@eskombro eskombro mentioned this pull request May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants