Implement new proximityPrecision #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=========================================
+ Coverage 0 99.62% +99.62%
=========================================
Files 0 9 +9
Lines 0 540 +540
=========================================
+ Hits 0 538 +538
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. |
|
Thank you for your continued contributions! Looks good to me so far, I will wait for you to add tests and mark it ready for review. |
added 2 commits
January 16, 2024 22:50
ellnix
suggested changes
Jan 16, 2024
|
@ellnix sorry for the small mistakes |
ellnix
suggested changes
Jan 16, 2024
ellnix
reviewed
Jan 16, 2024
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Jan 16, 2024
512: Implement new proximityPrecision r=ellnix a=andre-m-dev # Pull Request ## Related issue Fixes #511 ## What does this PR do? - Add proximityPrecision ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Andre <>
|
Build failed: |
|
bors try |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #511
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!