Skip to content

[v1.4] Support text-separator customization #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
10 tasks
curquiza opened this issue Sep 27, 2023 · 2 comments
Closed
10 tasks

[v1.4] Support text-separator customization #526

curquiza opened this issue Sep 27, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this central issue

  • Add two new settings: separatorTokens and nonSeparatorTokens with get, update, and reset methods associated.
    Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getSeparatorTokens(); // calls GET /indexes/:uid/settings/separator-tokens
client.index('indexName').updateSeparatorTokens(['|', '/', '&sep']);  // calls PUT /indexes/:uid/settings/separator-tokens
client.index('indexName').resetSeparatorTokens(); // calls DELETE /indexes/:uid/settings/separator-tokens

client.index('indexName').getNonSeparatorTokens(); // calls GET /indexes/:uid/settings/non-separator-tokens
client.index('indexName').updateNonSeparatorTokens(['@', '#']); // calls PUT /indexes/:uid/settings/non-separator-tokens
client.index('indexName').resetNonSeparatorTokens(); // calls DELETE /indexes/:uid/settings/non-separator-tokens
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2023
meili-bors bot added a commit that referenced this issue Jul 2, 2024
595: Supports text separation r=irevoire a=NoodleSamaChan

# Pull Request

## Related issue
#526

## What does this PR do?
Added two new settings: separatorTokens and nonSeparatorTokens with get, update, and reset methods associated.

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: NoodleSamaChan <[email protected]>
Co-authored-by: NoodleSamaChan <[email protected]>
@ellnix
Copy link
Contributor

ellnix commented Apr 11, 2025

This looks like it should be closed but the associated PR didn't have the "Fixes" keyword.

@curquiza
Copy link
Member Author

You are right, thank you @ellnix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants