Skip to content

Fix update index code sample #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Fix update index code sample #294

merged 2 commits into from
Jun 7, 2022

Conversation

bidoubiwa
Copy link
Contributor

Function usage was wrong, this PR fixes it

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jun 2, 2022
@bidoubiwa bidoubiwa requested review from alallema and irevoire June 6, 2022 10:26
@brunoocasali
Copy link
Member

@bidoubiwa this PR should be closed now?

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌯

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 7, 2022

Build succeeded:

@bors bors bot merged commit 09cb1cf into main Jun 7, 2022
@bors bors bot deleted the fix_update_index_code_sample branch June 7, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants