Skip to content

Update indexes for v0.28.0 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 66 commits into from
Aug 25, 2022

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Aug 22, 2022

Related to issue: meilisearch/meilisearch#2373

All the changes:

  • Remove the name field in the index.
  • Wrap the indexes objects in a results key.
  • GET /indexes has pagination metadata, added limit (default: 20), offset (default: 0), total.

Breaking changes

  • client.get_indexes now returns a IndexesResults instead of a Vec<Index>
  • client.get_indexes_raw now returns a Value instead of a Vec<Value>
  • Index structure:
    • uid is now a string and not a Arc<string> and is public
    • client is now public
    • primary_key is now public

New

  • client.get_indexes_with takes as argument IndexesQuery giving you the possibility to set limit and offset.
  • client.get_indexes_raw_with takes as argument IndexesQuery giving you the possibility to set limit and offset.
  • IndexUpdater struct gives you the possibility to create an instance of all the fields you would like to change in an Index and then execute the update: `IndexUpdater::new(&client).with_primary_key("my_id".to_string()).execute().await)
  • IndexesQuery struct allows you to define the filtering applied during the get_all_indexes_with call.

@bidoubiwa bidoubiwa requested review from irevoire and alallema August 24, 2022 10:29
@bidoubiwa bidoubiwa marked this pull request as ready for review August 24, 2022 10:31
@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Aug 24, 2022
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly noice
image

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @bidoubiwa just a few questions here ✨

@bidoubiwa bidoubiwa requested review from alallema and irevoire August 24, 2022 16:10
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coolos

Base automatically changed from update_keys_for_v0.28.0 to bump-meilisearch-v0.28.0 August 25, 2022 11:20
@bidoubiwa bidoubiwa merged commit 5ce98c7 into bump-meilisearch-v0.28.0 Aug 25, 2022
@bidoubiwa bidoubiwa deleted the update_indexes_for_v0.28.0 branch August 25, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants