Skip to content

Improves error handling by using thiserror lib #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2022
Merged

Improves error handling by using thiserror lib #356

merged 6 commits into from
Oct 13, 2022

Conversation

romilpunetha
Copy link
Contributor

@romilpunetha romilpunetha commented Oct 12, 2022 •
edited
Loading

Pull Request

Related issue

Fixes #311 and #162

What does this PR do?

  • Updates errors.rs to use thiserror lib thereby simplifying how errors are managed.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@romilpunetha romilpunetha marked this pull request as ready for review October 12, 2022 17:49
@romilpunetha
Copy link
Contributor Author

@bidoubiwa

irevoire
irevoire previously approved these changes Oct 13, 2022
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @romilpunetha

@bidoubiwa
Copy link
Contributor

Hey @romilpunetha!

Thanks for your contirbution 🙏 Could you run cargo fmt locally? We forgot to add it in the contributing guide.
I added it in #357. Sorry for that

@romilpunetha
Copy link
Contributor Author

romilpunetha commented Oct 13, 2022 •
edited
Loading

Hey @romilpunetha!

Thanks for your contirbution 🙏 Could you run cargo fmt locally? We forgot to add it in the contributing guide.
I added it in #357. Sorry for that

Done

@bidoubiwa bidoubiwa added the enhancement New feature or request label Oct 13, 2022
@bidoubiwa bidoubiwa added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) and removed enhancement New feature or request labels Oct 13, 2022
bidoubiwa
bidoubiwa approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 13, 2022

Build succeeded:

@bors bors bot merged commit 920cdd6 into meilisearch:main Oct 13, 2022
@bidoubiwa
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@romilpunetha romilpunetha deleted the feat/thiserror branch October 13, 2022 12:20
@romilpunetha romilpunetha mentioned this pull request Oct 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@irevoire irevoire irevoire left review comments

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use thiserror to handle errors
3 participants
@romilpunetha @bidoubiwa @irevoire