Add get documents filter field for ms v1.2 #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
force-pushed
the
add_get_documents_filter_field_for_ms_v1.2
branch
3 times, most recently
from
6cc03eb to
673e1d4
Compare
alallema
reviewed
May 24, 2023
bidoubiwa
force-pushed
the
add_get_documents_filter_field_for_ms_v1.2
branch
from
673e1d4 to
13e8576
Compare
bidoubiwa
force-pushed
the
add_get_documents_filter_field_for_ms_v1.2
branch
3 times, most recently
from
fc5be60 to
d8c927a
Compare
|
I'v added a new test @alallema
|
bidoubiwa
force-pushed
the
add_get_documents_filter_field_for_ms_v1.2
branch
3 times, most recently
from
7014e1f to
4a82f91
Compare
bidoubiwa
force-pushed
the
add_get_documents_filter_field_for_ms_v1.2
branch
from
4a82f91 to
bbb6322
Compare
meili-bors bot
added a commit
that referenced
this pull request
Jun 5, 2023
476: Update version for the next release (v0.24.0) r=bidoubiwa a=meili-bot Release CHANGELOG: This version introduces features released on Meilisearch v1.2.0 🎉 Check out the changelog of [Meilisearch v1.2.0](https://github.com/meilisearch/meilisearch/releases/tag/v1.2.0) for more information on the changes.⚠️ If you want to adopt new features of this release, **update the Meilisearch server** to the according version. ### 🚀 Enhancements - Add a new `index.delete_documents_with(DocumentDeletionQuery)` method, which takes as a parameter a `DocumentDeletionQuery` struct. The struct has one builder method, `with_filter(filter: &str)`. The `filter` works precisely like the `filter` field used with the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)) and lets you determine which documents should be deleted. #472 `@bidoubiwa` - Add a new builder method `with_filter(filter: &str)` on `DocumentDeletionQuery` struct used by `index.get_documents_with`. The `filter` works precisely like the `filter` field used with the `search` method (see [the docs on how to use filters](https://www.meilisearch.com/docs/learn/advanced/filtering#filter-basics)) and lets you determine which documents should be fetched. #473 `@bidoubiwa` These feature requires a Meilisearch server version greater than v1.2. Thanks again to `@bidoubiwa!` 🎉 477: Update code-samples for v1.2 r=bidoubiwa a=meili-bot _This PR is auto-generated._ Update the code-samples.meilisearch.yml according to the [integration-guides issue](meilisearch/integration-guides#270) for more information and the complete description about what should be done here check that issue. This is the [central issue](meilisearch/integration-guides#261) about the Meilisearch release v1.2 in the integrations. Co-authored-by: meili-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per the specification: meilisearch/specifications#234
with_filteron theDocumentQuerystructure.The
filterfield works precisely like thefilterfield used on thesearchmethod. See the docs on how to use filters.