Skip to content

created new snapshot method - fixes #537 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

NoodleSamaChan
Copy link
Contributor

Pull Request

Related issue

Fixes #537

What does this PR do?

  • creates new snapshot method

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

irevoire
irevoire previously approved these changes Apr 17, 2024
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

bors merge

meili-bors bot added a commit that referenced this pull request Apr 17, 2024
572: created new snapshot method - fixes #537 r=irevoire a=NoodleSamaChan

# Pull Request

## Related issue
Fixes #537

## What does this PR do?
- creates new snapshot method

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: NoodleSamaChan <[email protected]>
Copy link
Contributor

meili-bors bot commented Apr 17, 2024

Build failed:

@curquiza curquiza added the enhancement New feature or request label Apr 17, 2024
@curquiza
Copy link
Member

@NoodleSamaChan thank you for your PR
Looks like there is an issue with the formating of rust. Can you fix it?

Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tanks @curquiza & @NoodleSamaChan

bors merge

@NoodleSamaChan
Copy link
Contributor Author

apologies for the bother, I redid the formatting, hope it fixes the issue!

Copy link
Contributor

meili-bors bot commented Apr 17, 2024

Build succeeded:

@meili-bors meili-bors bot merged commit 2a9d645 into meilisearch:main Apr 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.5] Add a new method for creating snapshots
3 participants