Skip to content

Update api to task api #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Feb 10, 2022
Merged

Update api to task api #248

merged 35 commits into from
Feb 10, 2022

Conversation

bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Jan 7, 2022 •
edited
Loading

BREAKING:

  • Task structure introduced
  • all actions on Indexes except get now return a Task :
    • updateIndex
    • createIndex
    • deleteIndex
  • waitForPendingUpdate is removed and waitForTask is introduced as replacement
  • getStatusUpdate and getAllStatusUpdates are removed.
  • getTask and getTasks introduced on Indexes and Client class.
  • All routes returning an Update return now a Task

Small changes

  • Replaced all print(error) with dump(error)
  • Used utils function in test to avoid code duplication
  • Added and removed newlines for readability
  • replaced waitForTask utils function with client.waitForTask in tests

@bidoubiwa bidoubiwa changed the base branch from main to bump-meilisearch-v0.25.0 January 7, 2022 13:16
@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Feb 6, 2022
@bidoubiwa bidoubiwa requested a review from alallema February 7, 2022 11:13
bidoubiwa
bidoubiwa commented Feb 7, 2022
View reviewed changes
bidoubiwa
bidoubiwa commented Feb 7, 2022
View reviewed changes
@bidoubiwa bidoubiwa force-pushed the update_api_to_task_api branch from 95bc47d to 214d102 Compare February 8, 2022 11:14
alallema
alallema reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done 💪 @bidoubiwa!!!
I let few comments

bidoubiwa and others added 2 commits February 8, 2022 15:09
alallema
alallema approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🍁

@bidoubiwa bidoubiwa force-pushed the update_api_to_task_api branch from 64e0e04 to f611706 Compare February 8, 2022 15:49
brunoocasali
brunoocasali reviewed Feb 9, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments about the implementation and tests, but I couldn't see everything! 😅

Awesome work @bidoubiwa 🌮 🌮

@bidoubiwa bidoubiwa mentioned this pull request Feb 10, 2022
Closed
brunoocasali
brunoocasali approved these changes Feb 10, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦅 LGTM! 🎉

Very good @bidoubiwa v0.25 here we go!

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 10, 2022

Build succeeded:

@bors bors bot merged commit f5a5209 into bump-meilisearch-v0.25.0 Feb 10, 2022
@bors bors bot deleted the update_api_to_task_api branch February 10, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bidoubiwa @brunoocasali @alallema