Skip to content

Fix-#363 'type should be enum' #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dishant10 wants to merge 3 commits into from
Closed

Fix-#363 'type should be enum' #375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1a196a
Fix-#363 type should be enum
Dishant10 Mar 17, 2023
11473f8
Fix issues mentioned in Linter messages
Dishant10 Mar 18, 2023
d043ee3
Added Codable functionality
Dishant10 Mar 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Sources/MeiliSearch/Model/Task.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,20 @@ public struct Task: Codable, Equatable {
public let status: Task.Status

/// Type of the task.
public let type: String
//public let type: String
Copy link
Member

@brunoocasali brunoocasali Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should remove this comment.

public enum Type:Codable {
Copy link
Member

@brunoocasali brunoocasali Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, there is some GithubAction annotations, please fix them:

image

case indexCreation
Copy link
Member

@brunoocasali brunoocasali Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation is not following the guidelines of the project. Also, you can move this enum to the bottom of the file but still inside of the scope of the public struct Task.

Type is a protected word in Swift, so you can use TaskType instead.

case indexUpdate
case indexDeletion
case indexSwap
case documentAdditionOrUpdate
case documentDeletion
case settingsUpdate
case dumpCreation
case taskCancelation
case taskDeletion
case snapshotCreation
Copy link
Member

@brunoocasali brunoocasali Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still have to fix these typing errors to make your tests pass:

image

Example, from this:

XCTAssertEqual("indexCreation", task.type)
to this:
XCTAssertEqual(Task.TaskType.indexCreation, task.type)

}

/// Details of the task.
public let details: Details?
Expand Down