Changes for v1.5, v1.6, v1.7 and v1.8 #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #433
This just makes it simpler to run Integration Tests with a locally installed version of MeiliSearch. This commit also fixes a SwiftLint warning (whitespace).
Missed requirement in previous commits
Working on CI Fixes
meili-bors bot
added a commit
that referenced
this pull request
Jan 7, 2025
459: Changes for v1.5, v1.6, v1.7 and v1.8 r=curquiza a=Sherlouk Some quite repetitive changes here, so just cranking them out in one PR. **No breaking changes**. Integration tests all in tact and updated. Verified locally. Closes #433 Closes #436 Closes #439 Closes #443 Co-authored-by: James Sherlock <[email protected]> Co-authored-by: James Sherlock <[email protected]>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches","status":"422"} |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quite repetitive changes here, so just cranking them out in one PR. No breaking changes. Integration tests all in tact and updated. Verified locally.
Closes #433
Closes #436
Closes #439
Closes #443