Apply task changes #188
Merged
Apply task changes #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
reviewed
Jul 5, 2022
| @@ -162,7 +162,7 @@ public function testPreRemoveWithObjectId(): void | |||
| */ | |||
| private function waitForAllTasks(): void | |||
| { | |||
| $firstTask = $this->client->getTasks()['results'][0]; | |||
| $firstTask = $this->client->getTasks()->getResults()[0]; | |||
There was a problem hiding this comment.
What is the new return type of getTasks, it was an array before, right?
There was a problem hiding this comment.
Yes! But now we expose a TasksResults instead of the plain array. https://github.com/meilisearch/meilisearch-php/pull/346/files#diff-a89919ef9dd9fd7b26588c14dfede73eedb183d875b989ac6c1ee9358f02114bR17
There was a problem hiding this comment.
Intrinsically is the same behavior but the correct way to access this value is through the getter :)
curquiza
approved these changes
Jul 5, 2022
brunoocasali
added a commit
that referenced
this pull request
Jul 11, 2022
brunoocasali
added
the
skip-changelog
brunoocasali
added a commit
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uidbytaskUid['results']by->getResults()TODO:
meilisearch-phpafter the release.