Skip to content

Conversation

@norkunas
Copy link
Collaborator

@norkunas norkunas commented Sep 5, 2024

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the bug Something isn't working label Sep 5, 2024
@codecov
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (d5fca7a) to head (98923ae).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Command/MeilisearchImportCommand.php 0.00% 1 Missing ⚠️
src/Services/SettingsUpdater.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #349   +/-   ##
=========================================
  Coverage     87.75%   87.75%           
  Complexity        1        1           
=========================================
  Files            20       20           
  Lines           874      874           
=========================================
  Hits            767      767           
  Misses          107      107           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@norkunas norkunas merged commit d3d3f97 into meilisearch:main Sep 6, 2024
@norkunas norkunas deleted the fix-err-msg branch September 6, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant