Skip to content

Conversation

@norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Makes all tests final;
  • Removes unused methods from test fixtures;
  • Removes helper methods to create fixtures and instead inlines the creation to flush once instead of flushing to database after each entity creation;
  • Adds missing types to test fixtures;
  • Removes fixture creation with passing arguments as array for better static analysis;
  • Adds matthiasnoback/symfony-config-test for bundle config test;
  • Refactor bundle config test data provider to use generator instead of returning a single array;
  • Replaces datetime mutable to datetime immutable in tests as mutable should be discouraged;

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Oct 15, 2024
@norkunas norkunas requested a review from curquiza October 15, 2024 15:43
@norkunas norkunas force-pushed the cs branch 2 times, most recently from 9478085 to 3b2d4b6 Compare October 15, 2024 15:45
@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.62%. Comparing base (396ff0e) to head (19e198e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #358   +/-   ##
=========================================
  Coverage     88.62%   88.62%           
  Complexity        1        1           
=========================================
  Files            20       20           
  Lines           897      897           
=========================================
  Hits            795      795           
  Misses          102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiiiice

bors merge

@meili-bors meili-bors bot merged commit a420c1f into meilisearch:main Oct 16, 2024
@norkunas norkunas deleted the cs branch October 16, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants