-
Notifications
You must be signed in to change notification settings - Fork 34
Prepare release #396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release #396
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughBumped Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
35f9e36 to
e479bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/MeilisearchBundle.php (1)
11-16: Optional: derive version from Composer to avoid manual bumps.Use InstalledVersions when available, falling back to the constant.
- public const VERSION = '0.15.9'; + public const VERSION = '0.15.9'; // fallback when Composer metadata unavailable @@ - public static function qualifiedVersion(): string - { - return \sprintf('Meilisearch Symfony (v%s)', self::VERSION); - } + public static function version(): string + { + if (\class_exists(\Composer\InstalledVersions::class) + && \Composer\InstalledVersions::isInstalled('meilisearch/meilisearch-symfony')) { + return \Composer\InstalledVersions::getPrettyVersion('meilisearch/meilisearch-symfony') ?? self::VERSION; + } + return self::VERSION; + } + + public static function qualifiedVersion(): string + { + return \sprintf('Meilisearch Symfony (v%s)', self::version()); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/MeilisearchBundle.php(1 hunks)
🔇 Additional comments (2)
src/MeilisearchBundle.php (2)
11-11: Version bump looks good.Constant updated to 0.15.9; no functional impact beyond qualifiedVersion() output.
11-11: No lingering 0.15.8 references detected
Scanned all non-vendor files for “0.15.8” or “Meilisearch Symfony (v)”—none found. Version bump to 0.15.9 is consistent.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=========================================
Coverage 88.40% 88.40%
Complexity 1 1
=========================================
Files 20 20
Lines 888 888
=========================================
Hits 785 785
Misses 103 103 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Chores
Tests