Skip to content

Conversation

@norkunas
Copy link
Collaborator

@norkunas norkunas commented Sep 10, 2025

Summary by CodeRabbit

  • Chores

    • Bumped bundle version to 0.15.9 so UIs, logs, and diagnostics report the updated release.
    • No functional changes or breaking updates in this release.
  • Tests

    • Updated test baseline to ignore a specific deprecation message, reducing noise in test outputs.

@norkunas norkunas added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Sep 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Bumped MeilisearchBundle::VERSION from 0.15.8 to 0.15.9; added a new deprecation ignore entry to tests/baseline-ignore for a Doctrine native lazy objects deprecation message. No behavioral code changes beyond the version constant.

Changes

Cohort / File(s) Summary
Version bump
src/MeilisearchBundle.php
Updated public const VERSION from '0.15.8' to '0.15.9'; qualifiedVersion() now reflects 0.15.9.
Test baseline update
tests/baseline-ignore
Added ignored deprecation entry: %Since doctrine/doctrine-bundle 2.16: Not setting "doctrine.orm.enable_native_lazy_objects" to true is deprecated%.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Prepare release #396 — Same code-level change: bumps MeilisearchBundle::VERSION from 0.15.8 to 0.15.9.

Pre-merge checks (1 passed, 1 warning, 1 inconclusive)

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Title Check ❓ Inconclusive The title "Prepare release" is vague and does not clearly convey the main change of bumping the MeilisearchBundle VERSION constant from 0.15.8 to 0.15.9. Rename the title to specify the version change, for example "Bump MeilisearchBundle version to 0.15.9" so that it clearly reflects the primary change in this PR.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

Poem

A hop and a bump, 0.15.9 I cheer,
Ticking my whiskers—new version is here!
A tiny change, a tidy line,
Tests whisper warnings, all benign.
Thump-thump, little rabbit ships the sign.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 35f9e36 and e479bc2.

📒 Files selected for processing (2)
  • src/MeilisearchBundle.php (1 hunks)
  • tests/baseline-ignore (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/MeilisearchBundle.php (1)

11-16: Optional: derive version from Composer to avoid manual bumps.

Use InstalledVersions when available, falling back to the constant.

-    public const VERSION = '0.15.9';
+    public const VERSION = '0.15.9'; // fallback when Composer metadata unavailable
@@
-    public static function qualifiedVersion(): string
-    {
-        return \sprintf('Meilisearch Symfony (v%s)', self::VERSION);
-    }
+    public static function version(): string
+    {
+        if (\class_exists(\Composer\InstalledVersions::class)
+            && \Composer\InstalledVersions::isInstalled('meilisearch/meilisearch-symfony')) {
+            return \Composer\InstalledVersions::getPrettyVersion('meilisearch/meilisearch-symfony') ?? self::VERSION;
+        }
+        return self::VERSION;
+    }
+
+    public static function qualifiedVersion(): string
+    {
+        return \sprintf('Meilisearch Symfony (v%s)', self::version());
+    }
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9e1aaa4 and 35f9e36.

📒 Files selected for processing (1)
  • src/MeilisearchBundle.php (1 hunks)
🔇 Additional comments (2)
src/MeilisearchBundle.php (2)

11-11: Version bump looks good.

Constant updated to 0.15.9; no functional impact beyond qualifiedVersion() output.


11-11: No lingering 0.15.8 references detected
Scanned all non-vendor files for “0.15.8” or “Meilisearch Symfony (v)”—none found. Version bump to 0.15.9 is consistent.

@norkunas norkunas merged commit a5a19d8 into meilisearch:main Sep 10, 2025
20 of 21 checks passed
@norkunas norkunas deleted the prep-release branch September 10, 2025 09:45
@codecov
Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.40%. Comparing base (3deb3c9) to head (e479bc2).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #396   +/-   ##
=========================================
  Coverage     88.40%   88.40%           
  Complexity        1        1           
=========================================
  Files            20       20           
  Lines           888      888           
=========================================
  Hits            785      785           
  Misses          103      103           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant