Skip to content

Conversation

@Chris53897
Copy link
Contributor

@Chris53897 Chris53897 commented Nov 1, 2025

#398

Can we merge this to unblock tests for other PRs?

@coderabbitai
Copy link

coderabbitai bot commented Nov 1, 2025

Walkthrough

A deprecation notice is added to the baseline-ignore test file, indicating that the report_fields_where_declared configuration option will be removed in DoctrineBundle 3.0. No functional or structural changes are made.

Changes

Cohort / File(s) Summary
Deprecation Notice
tests/baseline-ignore
Added deprecation notice line for report_fields_where_declared configuration option, scheduled for removal in DoctrineBundle 3.0

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A notice hops onto the page so fine,
Deprecation warns: "Your time's running out of line!"
DoctrineBundle 3.0 draws near,
Old config fades, the future is clear.
Farewell, report_fields_where_declared, my dear! 🌿

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The PR title "test: extend baseline-ignore for report_fields_where_declared" is directly aligned with the changeset, which extends the tests/baseline-ignore file to add a deprecation notice for the report_fields_where_declared configuration option. The title uses a clear action verb ("extend"), specifies the target file (baseline-ignore), and identifies the specific feature being addressed (report_fields_where_declared). It is concise, avoids vague terms, and provides sufficient specificity for a teammate to understand the primary change from the title alone.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 752afde and 09f62a7.

📒 Files selected for processing (1)
  • tests/baseline-ignore (1 hunks)
🔇 Additional comments (1)
tests/baseline-ignore (1)

11-11: LGTM! Clean addition to the baseline-ignore file.

The deprecation pattern is correctly formatted and consistent with the existing entries. Ensure that this pattern accurately matches the actual deprecation warning being emitted during tests.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.38%. Comparing base (e479bc2) to head (09f62a7).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #407      +/-   ##
============================================
- Coverage     88.40%   88.38%   -0.02%     
  Complexity        1        1              
============================================
  Files            20       20              
  Lines           888      878      -10     
============================================
- Hits            785      776       -9     
+ Misses          103      102       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias!

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Nov 6, 2025

@meili-bors meili-bors bot merged commit 17d4948 into meilisearch:main Nov 6, 2025
23 of 24 checks passed
@Chris53897 Chris53897 deleted the feature/extend-baseline-ignore branch November 6, 2025 10:12
@curquiza curquiza added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Nov 6, 2025
@coderabbitai coderabbitai bot mentioned this pull request Nov 11, 2025
3 tasks
This was referenced Nov 26, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants