Skip to content

Remove the vector store backend from the settings - #6399

Merged
dureuill merged 3 commits into
mainfrom
vector-store-new-settings-indexer
Jun 11, 2026
Merged

Remove the vector store backend from the settings#6399
dureuill merged 3 commits into
mainfrom
vector-store-new-settings-indexer

Conversation

@Kerollmops

@Kerollmops Kerollmops commented May 20, 2026

Copy link
Copy Markdown
Member

This PR completely removes the possibility of changing the vector store backend.

Generative AI tools

  • This PR does not use generative AI tooling
  • This PR uses generative AI tooling and respects the related policies

@Kerollmops
Kerollmops requested a review from ManyTheFish May 20, 2026 12:47
@Kerollmops Kerollmops added the no db change The database didn't change label May 20, 2026
@ManyTheFish

Copy link
Copy Markdown
Member

I am not sure we want to introduce an error message forbidding the usage of this setting.

I would rather remove the setting completely, wdyt?

@Kerollmops
Kerollmops force-pushed the vector-store-new-settings-indexer branch from 052dddb to fa447bd Compare May 21, 2026 11:57
@Kerollmops Kerollmops changed the title Support the vector store backend in the new settings indexer Remove the vector store backend from the settings May 21, 2026
@Kerollmops
Kerollmops requested a review from dureuill May 21, 2026 11:58
Comment thread workloads/tests/hf-embed-hannoy.json
Comment thread workloads/tests/hf-embed.json
@Kerollmops
Kerollmops force-pushed the vector-store-new-settings-indexer branch from 6bcebe7 to 57da229 Compare May 21, 2026 14:23
@Kerollmops

Kerollmops commented May 21, 2026

Copy link
Copy Markdown
Member Author

I really don't get why this change is making the CI break:

- "VectorStoreBackend":
- {
-     "type": "string",
-     "enum":
-     [
-         "stable",
-         "experimental"
-     ]
- },

EDIT: doesn't seem related to this PR actually.

@Kerollmops
Kerollmops force-pushed the vector-store-new-settings-indexer branch from 57da229 to e330e45 Compare May 26, 2026 12:39
@Kerollmops
Kerollmops force-pushed the vector-store-new-settings-indexer branch from e330e45 to d444c2c Compare June 11, 2026 09:53

@dureuill dureuill left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dureuill
dureuill added this pull request to the merge queue Jun 11, 2026

@ManyTheFish ManyTheFish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Merged via the queue into main with commit dc2bff8 Jun 11, 2026
18 of 20 checks passed
@dureuill
dureuill deleted the vector-store-new-settings-indexer branch June 11, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no db change The database didn't change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants