Skip to content

Conversation

@mimartinez
Copy link
Contributor

Pull Request

Related issue

Fixes #85

What does this PR do?

  • Implement language translations for handling multi-language plugin
  • Added translation files en.json and es.json

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza requested a review from brunoocasali April 4, 2024 15:06
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heey @mimartinez thanks a lot for this PR!

I put some comments, lets discuss them, after that I will merge it :)

Thanks a lot!

@brunoocasali brunoocasali added the enhancement New feature or request label Apr 4, 2024
@mimartinez
Copy link
Contributor Author

Hi @brunoocasali,
Is there a problem with this PR, can I help?
Regards

@curquiza
Copy link
Member

Hello @mimartinez

@brunoocasali is still on Holiday and will review when he'll come back

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work here @mimartinez 🎉

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 16, 2024

@meili-bors meili-bors bot merged commit d6b0cbb into meilisearch:main May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle multi languages plugin

3 participants