-
Notifications
You must be signed in to change notification settings - Fork 65
Implement language translations for handling multi-language plugin #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement language translations for handling multi-language plugin #915
Conversation
brunoocasali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heey @mimartinez thanks a lot for this PR!
I put some comments, lets discuss them, after that I will merge it :)
Thanks a lot!
Co-authored-by: Bruno Casali <[email protected]>
|
Hi @brunoocasali, |
|
Hello @mimartinez @brunoocasali is still on Holiday and will review when he'll come back |
brunoocasali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work here @mimartinez 🎉
bors merge
Pull Request
Related issue
Fixes #85
What does this PR do?
en.jsonandes.jsonPR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!