fix(changelog): end each release block with a trailing newline#510
Merged
Conversation
A release whose last rendered element is a commit bullet (no tickets, so no appendix) ended without a newline, and the next release header got merged onto the bullet line. Emit a trim-proof trailing newline at the end of the body template so consecutive release blocks always separate. Ticket: QA-1670 Signed-off-by: Patryk Targowicz <patryk.targowicz@northern.tech>
Contributor
Author
|
this is issue that @mineralsfree discovered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast-follow fix for the config that went live in #504, reported on NorthernTechHQ/nt-gui#833: in a regenerated CHANGELOG, a release whose commits carry no tickets rendered its last bullet and the next release's
##header merged onto the same line (- Adjusted email endpoint## @northern.tech/store-0.41.0 - 2026-07-13).Root cause: git-cliff concatenates per-release body renders directly, and
trim = truestrips the template's own trailing newline — so a block only ended with a newline when the all-tickets appendix happened to render (its table rows carry one). Ticketless releases ended bare on the last bullet.Fix: emit a trim-proof trailing newline (
{% raw %}) at the end of the body template in bothcliff.tomlandcliff.toml.scoped, so every release block separates regardless of content.Reproduced the nt-gui case locally (three-tag repo, middle release ticketless) — merged line before, clean separation after. Full 24-commit fixture suite passes for both configs.
Ticket: QA-1670