Skip to content

Conversation

dinhlongviolin1
Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 commented Sep 11, 2025

Describe Your Changes

  • Add try catch to supported tool checks -> no error throwing in the chain -> not block other models

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Add try-catch to tool support checks in TauriProvidersService to prevent errors from blocking model processing.

  • Error Handling:
    • Add try-catch around tool support checks in TauriProvidersService in tauri.ts to prevent errors from blocking model processing.
    • Logs warning if tool support check fails, allowing model processing to continue without tool capabilities.
  • Behavior:
    • Ensures that models without tool capabilities can still be processed if tool support check fails.

This description was created by Ellipsis for 3a67cd6. You can customize this summary. It will automatically update as commits are pushed.

@dinhlongviolin1 dinhlongviolin1 changed the title Add try catch tool calls Add try catch tool calls (#6317) Sep 11, 2025
@dinhlongviolin1 dinhlongviolin1 changed the title Add try catch tool calls (#6317) bug: Deleted model file from imported models blocking model loading (#6317) Sep 11, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 3a67cd6 in 1 minute and 23 seconds. Click for details.
  • Reviewed 54 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/services/providers/tauri.ts:85
  • Draft comment:
    Good use of try-catch to handle errors from isToolSupported, preventing a single failure from blocking model refresh (resolves #6317).
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. web-app/src/services/providers/tauri.ts:97
  • Draft comment:
    Refactoring the inline ternary into an explicit block improves readability and maintainability of the model mapping logic.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_JIDUwMmDsyTHSr02

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

Barecheck - Code coverage report

Total: 29.47%

Your code coverage diff: -0.01% ▾

Uncovered files and lines
FileLines
web-app/src/services/providers/tauri.ts5-12, 14-15, 17-18, 20-27, 29-31, 33-34, 36-48, 50-54, 56-79, 82-84, 86-92, 94-95, 97-127, 129-134, 136-139, 141-144, 147-150, 153-156, 158-162, 164, 167, 169-170, 172-177, 179-189, 192-196, 198-200, 202-224

Copy link
Contributor

@dinhlongviolin1 dinhlongviolin1 merged commit 4856cfb into dev Sep 11, 2025
22 checks passed
@dinhlongviolin1 dinhlongviolin1 deleted the bug/fix-imported-model-error-handling branch September 11, 2025 08:56
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 11, 2025
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

bug: Model cant refresh if there is an error importing existing models
3 participants