Skip to content

Conversation

Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Sep 12, 2025

This pull request updates the CI/CD workflow configuration for the Jan Web Server, focusing on branch targeting and streamlining the preview deployment process. The main changes include switching workflow triggers to new branches, removing the preview manifest generation for pull requests, and updating the production deployment workflow to use branch-based triggers.

CI Workflow Updates

  • Changed workflow triggers in .github/workflows/jan-server-web-ci.yml to run on dev-web branch instead of dev for both push and pull request events. [1] [2]
  • Removed preview manifest generation and PR comment steps from the CI workflow, eliminating the creation and posting of preview URLs for pull requests.
  • Simplified the image tag setup by removing the unused SERVICE_NAME variable from the workflow.

Production Workflow Updates

  • Updated .github/workflows/jan-server-web-cicd-prod.yml to trigger on pushes to the prod-web branch and specific file paths, instead of using tag-based triggers.

Important

Update CI/CD workflows to use branch-based triggers and remove preview steps for Jan Web Server.

  • CI Workflow Updates
    • Change triggers in jan-server-web-ci.yml to dev-web branch for push and pull request events.
    • Remove preview manifest generation and PR comment steps.
    • Remove SERVICE_NAME variable from image tag setup.
  • Production Workflow Updates
    • Update jan-server-web-cicd-prod.yml to trigger on prod-web branch and specific file paths instead of tags.

This description was created by Ellipsis for 32440a9. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 32440a9 in 1 minute and 19 seconds. Click for details.
  • Reviewed 112 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 5 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-server-web-ci.yml:6
  • Draft comment:
    Branch trigger updated to 'dev-web'. Ensure this aligns with your branch strategy and that all relevant PRs target it.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
2. .github/workflows/jan-server-web-ci.yml:56
  • Draft comment:
    Removed the SERVICE_NAME variable since preview steps were dropped. Confirm no downstream dependency remains on SERVICE_NAME.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
3. .github/workflows/jan-server-web-ci.yml:71
  • Draft comment:
    The push step now runs conditionally on push events only. Verify that omitting image push on pull_request events is the desired behavior.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
4. .github/workflows/jan-server-web-cicd-prod.yml:4
  • Draft comment:
    Production workflow trigger now uses branch 'prod-web'. Ensure this change matches your deployment process, especially since the Cloudflare Pages step deploys from branch 'main'.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
5. .github/workflows/jan-server-web-ci.yml:7
  • Draft comment:
    Additional trigger paths (e.g., 'web-app/', 'extensions-web/', 'Makefile', 'package.json') are now included. Confirm these patterns are intended to trigger CI builds.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_qbZhO3XUQJVfqiQc

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit 7212811 into dev Sep 12, 2025
1 check passed
@github-project-automation github-project-automation bot moved this to QA in Jan Sep 12, 2025
@Minh141120 Minh141120 deleted the ci/separate-jan-web-build-and-deploy branch September 12, 2025 04:20
@github-actions github-actions bot added this to the v0.6.10 milestone Sep 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants