rtl_433_mqtt_hass, take config from env vars & externalise mappings. #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optionally take config from env vars * Move mappings to external file
|
I forgot to add that there is a small breaking change in that the --user argument is changed to --username to match --password which isn't abbreviated either. Additionally, it's easier to see the actual changes in the 2nd commit due to the way git decides whether a file is new or just moved. |
|
This pull request seems to change the entire file - so I have a conflict with it here #1665 |
|
https://github.com/pbkhrv/rtl_433-hass-addons has a docker file that runs this as an addon in homeassistant / hassio |
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
8e31ece to
e42ad33
Compare
zuckschwerdt
force-pushed
the
master
branch
2 times, most recently
from
93031a1 to
ed794ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a successor to the previous pull I cancelled. It allows you to configure rtl_433_mqtt_hass from environment vars, which can be overridden by cli args. Additionally I've moved the mappings out to a file so a user can maintain their own custom mappings more easily. I've added a Dockerfile that I use as it's pretty useful, and takes advantage of the environment vars. Lastly I've moved everything into it's own subfolder for clarity.