Add support for Rubicson pool thermometer 48942 #2137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zuckschwerdt
reviewed
Aug 5, 2022
zuckschwerdt
reviewed
Aug 5, 2022
zuckschwerdt
reviewed
Aug 5, 2022
zuckschwerdt
reviewed
Aug 5, 2022
robho
force-pushed
the
rubicson_pool
branch
3 times, most recently
from
cb26b4e to
23bc02b
Compare
|
I hope I got the indentation correct this time. Please take a look. |
zuckschwerdt
reviewed
Aug 5, 2022
|
First line for the doc comment needs to be a name, otherwise this looks good. Thanks! |
robho
commented
Aug 5, 2022
robho
force-pushed
the
rubicson_pool
branch
2 times, most recently
from
95ff29c to
b96f77d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.