Add support for EezTire TPMS10ATC E618 #2387
Conversation
This reverts commit 6d32e9d.
src/devices/tpms_eezrv.c
Outdated
| sprintf(flags_str, "%x", flags); | ||
| /* clang-format off */ | ||
| data_t *data = data_make( | ||
| "model", "", DATA_STRING, "EezTire TPMS10ATC", |
There was a problem hiding this comment.
I guess "10ATC" is 10 Anti Theft + Console package.
The sensors is "618E", model should be "EEZTire-618E"
Also add like in other TPMS:
"type", "", DATA_STRING, "TPMS",
src/devices/tpms_eezrv.c
Outdated
| /** @file | ||
| EezTire TPMS. | ||
|
|
||
| Copyright (C) 2023 ProfBoc75 and Gliebig |
There was a problem hiding this comment.
Usually this is peoples real names but feel free to leave it as is.
src/devices/tpms_eezrv.c
Outdated
| - C : 8 bit CheckSum | ||
| - I: 24 bit ID | ||
| - P: 8 bit pressue | ||
| - T: 8 bit temperature |
There was a problem hiding this comment.
Add units and scaling for temperature and pressure.
|
Just a few nits. Do we have test samples? If so maintainer_update changes can be added to the PR and then we can merge. |
Yes, we have sample made by @Gliebig here : https://github.com/Gliebig/rtl_433_tests/tree/master/tests/EEZ%20Tire%20TPMS/Model%20618E Corrections done, |
my last version, same as official PR as merbanan/rtl_433#2387
|
Are you waiting for me to do something on my end? If so, I don't know what it is you need me to do. |
|
All good, I'll merge this soon. |
as discussed into the issue #2384