Skip to content

Handle missing structure in TableStruct parameter_info#454

Merged
andlaus merged 2 commits intomercedes-benz:mainfrom
Nickkr:fix/table_struct_parameter_info
Mar 9, 2026
Merged

Handle missing structure in TableStruct parameter_info#454
andlaus merged 2 commits intomercedes-benz:mainfrom
Nickkr:fix/table_struct_parameter_info

Conversation

@Nickkr
Copy link

@Nickkr Nickkr commented Mar 9, 2026

Mirror behavior from TableStructParameter encode/decode methods, where a table row can point to either a structure or DOP. This was not reflected in the parameterinfo.

Mirror behavior from TableStructParameter encode/decode methods,
where a table row can point to either a structure or DOP.
This was not reflected in the parameterinfo.
@Nickkr Nickkr force-pushed the fix/table_struct_parameter_info branch from b32db12 to c5f604d Compare March 9, 2026 18:09
@Nickkr Nickkr changed the title Handle missing structure in TaleStruct parameter_info Handle missing structure in TableStruct parameter_info Mar 9, 2026
@andlaus
Copy link
Member

andlaus commented Mar 9, 2026

looks good. before I can merge it, you need to sign the CLA and reformat the code so that the automated style police is happy (just run the reformat-source.sh script in the top-level directory of your odxtools working copy).

@Nickkr
Copy link
Author

Nickkr commented Mar 9, 2026

Hi @andlaus. I ran the formatting script and pushed the changes, hope everything is fine now. :) I'm however seeing an issue when I try to sign the CLA. Here is the error I see, when I follow the link:

image

Could you support me with this? Not sure, whether I'm doing something wrong.

@andlaus
Copy link
Member

andlaus commented Mar 9, 2026

ok, the bot broke. anyway, the change is pretty trivial, so I'll merge. thanks!

@andlaus andlaus merged commit 10c0837 into mercedes-benz:main Mar 9, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants