perf: skip bunding Mermaid ZenUML#766
Merged
MindaugasLaganeckas merged 1 commit intomermaid-js:masterfrom Nov 12, 2024
Merged
Conversation
Instead of bundling the `@mermaid-js/mermaid-zenuml` package ourselves, we can let the user install their own version of it.
MindaugasLaganeckas
approved these changes
Nov 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
Instead of bundling the
@mermaid-js/mermaid-zenumlpackage ourselves, we can let the user install their own version of it.📏 Design Decisions
This lowers the size of the
dist/index.htmlfile by about 1.3 MB:Before
After
📋 Tasks
Make sure you
masterbranch