feat: add iconPacksNamesAndUrls option in order to be able to use icons outside unpkg#954
Merged
MindaugasLaganeckas merged 2 commits intomermaid-js:masterfrom Sep 14, 2025
Conversation
Member
|
Thank you for your PR. Please, add a simple end-to-end test here https://github.com/mermaid-js/mermaid-cli/blob/master/run-tests.sh, which will demonstrate the usage of the new option. Just have a look how other similar tests have been created. After that I will be happy to accept your PR. |
Author
|
Great ! |
… usage of iconPacksNamesAndUrls option
lmondeil1
force-pushed
the
feature/allowNotOnlyUnkpgIcons
branch
from
42d0fc1 to
a5e188c
Compare
Author
|
Hello @MindaugasLaganeckas. Is there something still missing on what I've done? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
iconPacksoption allows only to target icons stored in unpkgThere are icons available outside of unpkg (as the ones used on mermaid chart playground)
added
iconPacksNamesAndUrlsoption that looks likeiconPacksoption but gives the opportunity to use any valid Iconify json file (example : azure**#**https://raw.githubusercontent.com/NakayamaKento/AzureIcons/refs/heads/main/icons.json)