Skip to content

Fixed edge animation for hand drawn shapes#6843

Merged
shubhamparikh2704 merged 8 commits intomermaid-js:developfrom
saurabhg772244:saurabh/fix-edge-animation-for-hand-dranw-shapes
Oct 13, 2025
Merged

Fixed edge animation for hand drawn shapes#6843
shubhamparikh2704 merged 8 commits intomermaid-js:developfrom
saurabhg772244:saurabh/fix-edge-animation-for-hand-dranw-shapes

Conversation

@saurabhg772244
Copy link
Contributor

@saurabhg772244 saurabhg772244 commented Aug 11, 2025

📑 Summary

  • Fixed edge animation in hand drawn look

Resolves #

📏 Design Decisions

  • While drawing edge in hand drawn look edge-animation-* class was not getting applied.
  • Refactored code to add edge-animation-* class in hand drawn look.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Aug 11, 2025

🦋 Changeset detected

Latest commit: bbb93b2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 11, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit bbb93b2
🔍 Latest deploy log https://app.netlify.com/projects/mermaid-js/deploys/68c50a1cc4e0fa0008114d83
😎 Deploy Preview https://deploy-preview-6843--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 11, 2025

Open in StackBlitz

@mermaid-js/examples

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/examples@6843

mermaid

npm i https://pkg.pr.new/mermaid-js/mermaid@6843

@mermaid-js/layout-elk

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6843

@mermaid-js/layout-tidy-tree

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-tidy-tree@6843

@mermaid-js/mermaid-zenuml

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6843

@mermaid-js/parser

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6843

@mermaid-js/tiny

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/tiny@6843

commit: bbb93b2

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 3.56%. Comparing base (1c2a002) to head (bbb93b2).
⚠️ Report is 125 commits behind head on develop.

Files with missing lines Patch % Lines
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 18 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6843      +/-   ##
==========================================
- Coverage     3.56%   3.56%   -0.01%     
==========================================
  Files          473     473              
  Lines        47198   47207       +9     
  Branches       728     728              
==========================================
  Hits          1684    1684              
- Misses       45514   45523       +9     
Flag Coverage Δ
unit 3.56% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@argos-ci
Copy link

argos-ci bot commented Aug 11, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 13, 2025, 6:17 AM

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look great, just need a minor tweak on the class handling part to improve code quality.

@shubhamparikh2704 shubhamparikh2704 added this pull request to the merge queue Oct 13, 2025
Merged via the queue into mermaid-js:develop with commit 18f51eb Oct 13, 2025
22 checks passed
This was referenced Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants