fix(deps): move type-fest from devDependencies to dependencies#7433
Open
fix(deps): move type-fest from devDependencies to dependencies#7433
Conversation
type-fest types (SetRequired, SetOptional, RequiredDeep, Entries) are used in source files that produce published .d.ts declarations. With type-fest only in devDependencies, consumers get TS2307 errors when type-fest is not available transitively (e.g. after globals v14+ dropped its type-fest dependency). Resolves #6629 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: f8f7d73 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Type: Bug / Error
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7433 +/- ##
==========================================
- Coverage 3.55% 3.54% -0.02%
==========================================
Files 489 490 +1
Lines 48774 48938 +164
Branches 765 766 +1
==========================================
Hits 1734 1734
- Misses 47040 47204 +164
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
knsv-bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
Covers the regression from #7433 where done-task labels displayed outside the bar (text too wide for the bar width) rendered in unreadable dark color in dark theme. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
knsv-bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
…done tasks Split the dark mode done-task coverage into two explicit tests: - inside-text: label fits within the bar (long bar, short label) - outside-text: label overflows the bar (short bar, long label) — regression case for #7433 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
ashishjain0512
pushed a commit
that referenced
this pull request
Mar 6, 2026
…#7456) * fix(gantt): restore readable outside-text color for done tasks in dark mode When a Gantt done-task label is too wide to fit inside the bar, the renderer places the text outside (next to the bar) with class `taskTextOutsideLeft` or `taskTextOutsideRight` plus `doneText{N}`. The `.doneText{N}` rule uses `taskTextDarkColor !important`, which PR #7432 changed to a dark color (inverted from lightgrey) for contrast inside the bar. That `!important` also overrides the lighter `taskTextOutsideColor` that `.taskTextOutside{N}` sets, making outside-label text black/dark on the dark diagram background. Fix: add combined-class selectors (`.doneText{N}.taskTextOutsideLeft/Right`) after the `.doneText{N}` block, using `taskTextOutsideColor !important`. The combined selectors have higher specificity and appear later in the cascade, so they win over the single-class rule. Same fix applied to `.doneCritText{N}`. Fixes regression from PR #7432 (fix for #5979). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test(gantt): add e2e snapshot for done-task outside-text in dark mode Covers the regression from #7433 where done-task labels displayed outside the bar (text too wide for the bar width) rendered in unreadable dark color in dark theme. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * test(gantt): add separate inside/outside e2e snapshots for dark mode done tasks Split the dark mode done-task coverage into two explicit tests: - inside-text: label fits within the bar (long bar, short label) - outside-text: label overflows the bar (short bar, long label) — regression case for #7433 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: knsv-bot <knsv-bot@macos.shared> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6629
type-festfromdevDependenciestodependenciesinpackages/mermaid/package.jsontype-festtypes (SetRequired,SetOptional,RequiredDeep,Entries) are used in 5 source files whose declarations are published in thedist/.d.tsfiles. Withtype-festonly indevDependencies, consumers getTS2307: Cannot find module 'type-fest'errors whentype-festis not available transitively — which happens when packages likeglobals(v14+) drop their owntype-festdependency.Classification
package.jsonmanifest)Verification
pnpm build:mermaid)type-festindependencies, not indevDependencies🤖 Generated with Claude Code