Skip to content

fixed name collision for keyword NONE #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

dizcza
Copy link

@dizcza dizcza commented Oct 8, 2023

Embarrassingly, NONE enum collides with another NONE enum defined in ezTime.

Namespaces. Yeah.

Also, I'm a bit frustrated that Meshtastics has a fixed dependency on this oled lib even though I'm not using any oleds: I'm using a TFT display and LovyanGFX (not me but rather you in the Meshtastic display code). More bugs, more code, more space...

@dizcza
Copy link
Author

dizcza commented Oct 8, 2023

For instance, copied from src/graphics/TFTDisplay.cpp:

#elif defined(ST7735_CS)
#include <TFT_eSPI.h> // Graphics and font library for ILI9341 driver chip

static TFT_eSPI tft = TFT_eSPI(); // Invoke library, pins defined in User_Setup.h

#endif

@jp-bennett jp-bennett merged commit 9d393fe into meshtastic:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants