TST: enable --fatal-meson-warnings for all tests #768
Conversation
dnicolodi
force-pushed
the
meson-fatal-warnings
branch
3 times, most recently
from
2725c98 to
0173a9c
Compare
| c = '{arch}-apple-{subsystem}-clang' | ||
| cpp = '{arch}-apple-{subsystem}-clang++' | ||
| objc = '{arch}-apple-{subsystem}-clang' | ||
| objcpp = '{arch}-apple-{subsystem}-clang++' | ||
| ar = '{arch}-apple-{subsystem}-ar' | ||
| strip = ['strip', '-arch', {arch!r}] |
There was a problem hiding this comment.
@freakboy3742 Can you please verify that this is correct? I have no experience with building for iOS. Thanks!
There was a problem hiding this comment.
This will be a valid invocation for strip; but I've never needed to call strip on any iOS program, so I'm not sure where I'd be looking to verify this works. Have you got an example in mind that would be using this?
There was a problem hiding this comment.
Thanks! Maybe calling strip in this way and checking that the resulting binary is still working would be a way to verify that this does something that at least is not harmful. The reason I'm adding this is that, without it, meson emits a warning https://github.com/mesonbuild/meson-python/actions/runs/15653996265/job/44102572727#step:10:1105
There was a problem hiding this comment.
Understood - I'll investigate and report back shortly (likely tomorrow my time, at this point)
There was a problem hiding this comment.
I think the correct way to get to the strip utility is to run something like xcrun --sdk iphoneos -f strip. The system strip may not work for iOS binaries.
|
There are still test failures. These are the tests where we set the RPATH via explicit linker arguments. We stop doing that in #724 thus I don't think it is necessary to find a way to allow these warnings to do not make the tests fail. |
dnicolodi
force-pushed
the
meson-fatal-warnings
branch
from
0173a9c to
d674d94
Compare
The test packages also work as examples. I think it is better to make sure that they are as correct as possible.